Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated rotate file #2056

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: remove deprecated rotate file #2056

merged 1 commit into from
Dec 4, 2024

Conversation

schultzp2020
Copy link
Collaborator

Signed-off-by: Paul Schultz [email protected]

@schultzp2020 schultzp2020 requested a review from a team as a code owner December 4, 2024 14:56
@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
@schultzp2020
Copy link
Collaborator Author

/override markdown-link-check

The failing links are not related to this PR.

@schultzp2020 schultzp2020 merged commit b7d254b into main Dec 4, 2024
9 of 13 checks passed
@schultzp2020 schultzp2020 deleted the remove-rotate-file branch December 4, 2024 15:11
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2024

@schultzp2020: Overrode contexts on behalf of schultzp2020: markdown-link-check

In response to this:

/override markdown-link-check

The failing links are not related to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

The image is available at:

schultzp2020 added a commit that referenced this pull request Dec 4, 2024
@schultzp2020
chore: remove deprecated rotate file (#2056)
6e7046c 
Signed-off-by: Paul Schultz <[email protected]>
@kadel
Copy link
Member

kadel commented Dec 6, 2024

Is there a Jira for this? We are basically removing a feature here, so we will need at least a release note for this

@kadel
Copy link
Member

kadel commented Dec 9, 2024

This is documented downstream, so we also need Jira to track docs update and make sure that docs are updated before next release

https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.3/html/audit_log/index#ref-audit-log-file-rotation-overview_assembly-audit-log

@kadel
Copy link
Member

kadel commented Dec 9, 2024

It looks like this issue is related to https://issues.redhat.com/browse/RHIDP-4852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-tsao kim-tsao kim-tsao approved these changes

@dzemanov dzemanov Awaiting requested review from dzemanov

@its-mitesh-kumar its-mitesh-kumar Awaiting requested review from its-mitesh-kumar

Assignees

@kim-tsao kim-tsao

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schultzp2020 @kadel @kim-tsao